Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove obsolete Source Sans Pro ref from header #2501

Merged
merged 1 commit into from
Nov 30, 2023
Merged

chore: Remove obsolete Source Sans Pro ref from header #2501

merged 1 commit into from
Nov 30, 2023

Conversation

ianjon3s
Copy link
Contributor

What does this PR do?

The header files for PlanX contain obsolete references to Source Sans Pro, served from Google Fonts.

Removing these should save on potential unnecessary files being loaded in a user session.

@ianjon3s ianjon3s requested a review from a team November 30, 2023 12:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

jessicamcinchak
jessicamcinchak approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like map fonts are all coming through/inheriting as expected direct from web component and no longer relying on these imports 👍 thanks for tidying this up!!

Screenshot from 2023-11-30 14-06-12
Screenshot from 2023-11-30 14-05-51

@ianjon3s ianjon3s merged commit e2966c7 into main Nov 30, 2023
12 checks passed
@ianjon3s ianjon3s deleted the ian/remove-source-sans-font-refs branch November 30, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianjon3s @jessicamcinchak